[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

Mon Sep 2 01:22:31 PDT 2019

labath added inline comments.

================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:341
+  if (LIBLZMA_FOUND)
+	add_definitions(-DLLDB_ENABLE_LZMA)
+    include_directories(${LIBLZMA_INCLUDE_DIRS})
----------------
labath wrote:
> Please put this into `Config.h.cmake`. I know a lot of code in this file does not do that, but that's because we didn't have a Config.h back then.
(Among other things, this helps with incremental rebuilds, as only the files which include `Config.h` need to be recompiled)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66791/new/

https://reviews.llvm.org/D66791