[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 218265.
jankratochvil retitled this revision from "Prevent D66398 `TestDataFormatterStdList`-like regressions in the future" to "2/2: Process formatters in reverse-chronological order".
jankratochvil edited the summary of this revision.
jankratochvil added a reverted change: D66398: 2/2: Fix `TestDataFormatterStdList` regression.
jankratochvil added a comment.
Herald added a subscriber: abidh.

In D66654#1646544 <https://reviews.llvm.org/D66654#1646544>, @labath wrote:

> Personally, I'd go for the registration order,


Then you cannot override any existing formatter. Then it would be better to rather assert/error in such case which I tried to do in this patch but nobody likes this patch much.

> or possibly the reverse registration order,

That is what this new patch implements.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66654/new/

https://reviews.llvm.org/D66654

Files:
  lldb/include/lldb/DataFormatters/FormattersContainer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66654.218265.patch
Type: text/x-patch
Size: 5551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190901/6e8e07b8/attachment.bin>