[Lldb-commits] [PATCH] D67012: [lit] Only set DYLD_LIBRARY_PATH for shared builds

[Frederic Riss via Phabricator via lldb-commits]

friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

This looks good to me with one small provision:



================
Comment at: lldb/lit/CMakeLists.txt:72
   LLVM_ENABLE_ZLIB
+  LLVM_SHARED_LIBS
   LLDB_IS_64_BITS)
----------------
The other booleans have names that match boolean values (_DISABLE_, _ENABLE_, _IS_). Should we rename this to something like LLVM_IS_SHARED_BUILD? I'm terrible at names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67012/new/

https://reviews.llvm.org/D67012