[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 30 10:23:15 PDT 2019


amccarth added a comment.

I'll look at this in detail soon, but a few caveats:

- lldb tests don't work with the debug Python interpreter, which is why I've been complaining about test failures approximately forever when the bots seem fine.

- Some of these changes you're undoing caused a lot of pain when they were first put in, so let's be really sure if we need to undo this.

- I use the VS project only for code browsing and debugging.  For building and tests, I use the ninja project.  So I'm not very familiar with the problem you're trying to fix.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66994/new/

https://reviews.llvm.org/D66994





More information about the lldb-commits mailing list