[Lldb-commits] [lldb] r370483 - [lit] Fix my earlier bogus fix to not set DYLD_LIBRARY_PATH with Asan.
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Fri Aug 30 08:56:14 PDT 2019
Date: Fri Aug 30 08:56:14 2019
New Revision: 370483
[lit] Fix my earlier bogus fix to not set DYLD_LIBRARY_PATH with Asan.
My follow-up commit to mess with DYLD_LIBRARY_PATH was bogus for two
- The condition was inverted.
- We were checking the OS's environment, instead of the config's.
Two wrongs don't make a right, but the second mistake meant that the
sanitizer bot passed.
--- lldb/trunk/lit/Suite/lit.cfg (original)
+++ lldb/trunk/lit/Suite/lit.cfg Fri Aug 30 08:56:14 2019
@@ -39,7 +39,7 @@ def find_shlibpath_var():
elif platform.system() == 'Windows':
-if 'DYLD_INSERT_LIBRARIES' in os.environ:
+if not 'DYLD_INSERT_LIBRARIES' in config.environment:
# Shared library build of LLVM may require LD_LIBRARY_PATH or equivalent.
# This clashes with DYLD_INSERT_LIBRARIES which is needed on Darwin.
for shlibpath_var in find_shlibpath_var():
More information about the lldb-commits