[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.
Herald added a subscriber: ormris.


================
Comment at: lldb/trunk/lit/Settings/TestModuleCacheSanity.test:1-4
+# This is a sanity check that verifies that the module cache path is set
+# correctly and points inside the default test build directory.
+RUN: %lldb -o 'settings show symbols.clang-modules-cache-path' | FileCheck  %s
+CHECK: lldb-test-build.noindex{{.*}}module-cache-lldb
----------------
It seems weird to expose these as user-settable cmake variables, but then have a test which will fail if the user changes them in any way. Were you intending to have this feature be configurable at the cmake level? If not, could you change the cmake cache variables into something else (looks like regular variables should work just fine). If yes, then we should have a different testing strategy..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66966/new/

https://reviews.llvm.org/D66966