[Lldb-commits] [PATCH] D66739: [lldb] Add -w flag for expressions to print compiler warnings even if expression succeeds.

[Raphael Isemann via Phabricator via lldb-commits]

teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added subscribers: lldb-commits, abidh.
Herald added a project: LLDB.
teemperor edited the summary of this revision.

Currently if you evaluate for example "expression int" the user just sees nothing and has no way of knowing what
exactly could have gone wrong. This patch adds a `-w` flag to the expression command that causes compiler warnings
to be emitted even if the command succeeds. This was the agreed workaround to solve rdar://12788008.

The checkerror flag that was added to lldbtest was necessary as we usually don't check the error output of commands
when they succeed (but we have to do now).


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D66739

Files:
  lldb/include/lldb/Expression/UserExpression.h
  lldb/include/lldb/Target/Target.h
  lldb/packages/Python/lldbsuite/test/expression_command/warnings/Makefile
  lldb/packages/Python/lldbsuite/test/expression_command/warnings/TestExprWarnings.py
  lldb/packages/Python/lldbsuite/test/expression_command/warnings/main.cpp
  lldb/packages/Python/lldbsuite/test/lldbtest.py
  lldb/source/Commands/CommandObjectExpression.cpp
  lldb/source/Commands/CommandObjectExpression.h
  lldb/source/Commands/Options.td
  lldb/source/Expression/UserExpression.cpp
  lldb/source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66739.217133.patch
Type: text/x-patch
Size: 11354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190826/9e11ee17/attachment-0001.bin>