[Lldb-commits] [lldb] r369907 - Move ProcessInstanceInfoTest to Utility

[Pavel Labath via lldb-commits]

Author: labath
Date: Mon Aug 26 06:07:02 2019
New Revision: 369907

URL: http://llvm.org/viewvc/llvm-project?rev=369907&view=rev
Log:
Move ProcessInstanceInfoTest to Utility

The class under test was moved in r355342. This moves the test code too.

Added:
    lldb/trunk/unittests/Utility/ProcessInstanceInfoTest.cpp
      - copied, changed from r369906, lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp
Removed:
    lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp
Modified:
    lldb/trunk/unittests/Target/CMakeLists.txt
    lldb/trunk/unittests/Utility/CMakeLists.txt

Modified: lldb/trunk/unittests/Target/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Target/CMakeLists.txt?rev=369907&r1=369906&r2=369907&view=diff
==============================================================================
--- lldb/trunk/unittests/Target/CMakeLists.txt (original)
+++ lldb/trunk/unittests/Target/CMakeLists.txt Mon Aug 26 06:07:02 2019
@@ -3,7 +3,6 @@ add_lldb_unittest(TargetTests
   MemoryRegionInfoTest.cpp
   ModuleCacheTest.cpp
   PathMappingListTest.cpp
-  ProcessInstanceInfoTest.cpp
 
   LINK_LIBS
       lldbCore

Removed: lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp?rev=369906&view=auto
==============================================================================
--- lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp (original)
+++ lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp (removed)
@@ -1,93 +0,0 @@
-//===-- ProcessInstanceInfoTest.cpp -----------------------------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "lldb/Target/Process.h"
-#include "gtest/gtest.h"
-
-using namespace lldb_private;
-
-namespace {
-/// A very simple resolver which fails for even ids and returns a simple string
-/// for odd ones.
-class DummyUserIDResolver : public UserIDResolver {
-protected:
-  llvm::Optional<std::string> DoGetUserName(id_t uid) override {
-    if (uid % 2)
-      return ("user" + llvm::Twine(uid)).str();
-    return llvm::None;
-  }
-
-  llvm::Optional<std::string> DoGetGroupName(id_t gid) override {
-    if (gid % 2)
-      return ("group" + llvm::Twine(gid)).str();
-    return llvm::None;
-  }
-};
-} // namespace
-
-TEST(ProcessInstanceInfo, Dump) {
-  ProcessInstanceInfo info("a.out", ArchSpec("x86_64-pc-linux"), 47);
-  info.SetUserID(1);
-  info.SetEffectiveUserID(2);
-  info.SetGroupID(3);
-  info.SetEffectiveGroupID(4);
-
-  DummyUserIDResolver resolver;
-  StreamString s;
-  info.Dump(s, resolver);
-  EXPECT_STREQ(R"(    pid = 47
-   name = a.out
-   file = a.out
-   arch = x86_64-pc-linux
-    uid = 1     (user1)
-    gid = 3     (group3)
-   euid = 2     ()
-   egid = 4     ()
-)",
-               s.GetData());
-}
-
-TEST(ProcessInstanceInfo, DumpTable) {
-  ProcessInstanceInfo info("a.out", ArchSpec("x86_64-pc-linux"), 47);
-  info.SetUserID(1);
-  info.SetEffectiveUserID(2);
-  info.SetGroupID(3);
-  info.SetEffectiveGroupID(4);
-
-  DummyUserIDResolver resolver;
-  StreamString s;
-
-  const bool show_args = false;
-  const bool verbose = true;
-  ProcessInstanceInfo::DumpTableHeader(s, show_args, verbose);
-  info.DumpAsTableRow(s, resolver, show_args, verbose);
-  EXPECT_STREQ(
-      R"(PID    PARENT USER       GROUP      EFF USER   EFF GROUP  TRIPLE                   ARGUMENTS
-====== ====== ========== ========== ========== ========== ======================== ============================
-47     0      user1      group3     2          4          x86_64-pc-linux          
-)",
-      s.GetData());
-}
-
-TEST(ProcessInstanceInfo, DumpTable_invalidUID) {
-  ProcessInstanceInfo info("a.out", ArchSpec("x86_64-pc-linux"), 47);
-
-  DummyUserIDResolver resolver;
-  StreamString s;
-
-  const bool show_args = false;
-  const bool verbose = false;
-  ProcessInstanceInfo::DumpTableHeader(s, show_args, verbose);
-  info.DumpAsTableRow(s, resolver, show_args, verbose);
-  EXPECT_STREQ(
-      R"(PID    PARENT USER       TRIPLE                   NAME
-====== ====== ========== ======================== ============================
-47     0                 x86_64-pc-linux          a.out
-)",
-      s.GetData());
-}

Modified: lldb/trunk/unittests/Utility/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/CMakeLists.txt?rev=369907&r1=369906&r2=369907&view=diff
==============================================================================
--- lldb/trunk/unittests/Utility/CMakeLists.txt (original)
+++ lldb/trunk/unittests/Utility/CMakeLists.txt Mon Aug 26 06:07:02 2019
@@ -18,6 +18,7 @@ add_lldb_unittest(UtilityTests
   NameMatchesTest.cpp
   PredicateTest.cpp
   ProcessInfoTest.cpp
+  ProcessInstanceInfoTest.cpp
   RangeMapTest.cpp
   RangeTest.cpp
   RegisterValueTest.cpp

Copied: lldb/trunk/unittests/Utility/ProcessInstanceInfoTest.cpp (from r369906, lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp)
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/ProcessInstanceInfoTest.cpp?p2=lldb/trunk/unittests/Utility/ProcessInstanceInfoTest.cpp&p1=lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp&r1=369906&r2=369907&rev=369907&view=diff
==============================================================================
    (empty)