[Lldb-commits] [PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

Wed Aug 14 11:10:34 PDT 2019

cishida updated this revision to Diff 215174.
cishida added a comment.
Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, jdoerfert, asbirlea, Petar.Avramovic, thopre, jsji, jfb, kadircet, rupprecht, arphaman, atanasyan, jkorous, MaskRay, jrtc27, christof, cryptoad, kbarton, aheejin, jgravelle-google, arichardson, sbc100, javed.absar, mgorny, nhaehnle, jvesely, nemanjai, sdardis, emaste, dschuff, srhines.
Herald added a reviewer: bollu.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: martong.
Herald added a reviewer: espindola.
Herald added a reviewer: jfb.
Herald added a reviewer: shafik.
Herald added a reviewer: jdoerfert.
Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP.

- Reverse order of conditional for file_magic

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66149/new/

https://reviews.llvm.org/D66149

Files:
  clang-tools-extra/clangd/AST.cpp
  clang-tools-extra/clangd/FindSymbols.cpp
  clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
  clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts
  clang-tools-extra/clangd/clients/clangd-vscode/test/semantic-highlighting.test.ts
  clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp
  clang-tools-extra/clangd/unittests/TweakTesting.h
  clang/docs/LanguageExtensions.rst
  clang/docs/ReleaseNotes.rst
  clang/examples/clang-interpreter/main.cpp
  clang/include/clang/AST/ASTImporter.h
  clang/include/clang/AST/FormatString.h
  clang/include/clang/AST/RawCommentList.h
  clang/include/clang/Analysis/CFG.h
  clang/include/clang/Basic/Features.def
  clang/include/clang/Basic/IdentifierTable.h
  clang/include/clang/Basic/TokenKinds.def
  clang/include/clang/Driver/Driver.h
  clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h
  clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
  clang/include/clang/Tooling/AllTUsExecution.h
  clang/include/clang/Tooling/Execution.h
  clang/include/clang/Tooling/Refactoring/Extract/SourceExtraction.h
  clang/include/clang/Tooling/StandaloneExecution.h
  clang/lib/AST/ASTImporter.cpp
  clang/lib/AST/FormatStringParsing.h
  clang/lib/AST/PrintfFormatString.cpp
  clang/lib/Analysis/CFG.cpp
  clang/lib/Basic/IdentifierTable.cpp
  clang/lib/CodeGen/BackendUtil.cpp
  clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/DirectoryWatcher/CMakeLists.txt
  clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp
  clang/lib/Driver/Driver.cpp
  clang/lib/Driver/ToolChains/HIP.cpp
  clang/lib/Lex/PPMacroExpansion.cpp
  clang/lib/Sema/SemaChecking.cpp
  clang/lib/Sema/SemaInit.cpp
  clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp
  clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp
  clang/lib/StaticAnalyzer/Checkers/ObjCContainersChecker.cpp
  clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.h
  clang/lib/StaticAnalyzer/Checkers/UndefCapturedBlockVarChecker.cpp
  clang/lib/StaticAnalyzer/Core/BugReporter.cpp
  clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
  clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
  clang/lib/Tooling/Refactoring/Extract/Extract.cpp
  clang/lib/Tooling/Refactoring/Extract/SourceExtraction.cpp
  clang/lib/Tooling/Refactoring/Extract/SourceExtraction.h
  clang/lib/Tooling/Refactoring/Transformer.cpp
  clang/test/Analysis/Inputs/ctu-other.cpp
  clang/test/Analysis/Inputs/ctu-other.cpp.externalDefMap.txt
  clang/test/Analysis/checker-plugins.c
  clang/test/Analysis/ctu-main.cpp
  clang/test/Analysis/diagnostics/find_last_store.c
  clang/test/Analysis/exploded-graph-rewriter/escapes.c
  clang/test/Analysis/exploded-graph-rewriter/explorers.dot
  clang/test/Analysis/exploded-graph-rewriter/lit.local.cfg
  clang/test/Analysis/exploded-graph-rewriter/store.dot
  clang/test/Analysis/exploded-graph-rewriter/trimmers.dot
  clang/test/Analysis/track-control-dependency-conditions.cpp
  clang/test/Analysis/uninit-const.c
  clang/test/Analysis/uninit-const.cpp
  clang/test/Analysis/uninit-vals.c
  clang/test/CodeGen/struct-copy.c
  clang/test/CodeGen/tbaa-struct.cpp
  clang/test/CodeGen/wasm-varargs.c
  clang/test/CodeGenCoroutines/coro-retcon-unreachable.ll
  clang/test/Misc/printer.c
  clang/test/Preprocessor/feature_tests.c
  clang/test/Preprocessor/feature_tests.cpp
  clang/test/Refactor/Extract/ExtractionSemicolonPolicy.cpp
  clang/test/Sema/warn-lifetime-analysis-nocfg.cpp
  clang/test/SemaObjC/format-strings-objc.m
  clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp
  clang/tools/libclang/CXIndexDataConsumer.cpp
  clang/tools/libclang/CXIndexDataConsumer.h
  clang/unittests/Analysis/CFGTest.cpp
  clang/unittests/Tooling/ExecutionTest.cpp
  clang/utils/analyzer/exploded-graph-rewriter.py
  compiler-rt/lib/scudo/standalone/local_cache.h
  compiler-rt/lib/scudo/standalone/mutex.h
  compiler-rt/lib/scudo/standalone/primary32.h
  compiler-rt/lib/scudo/standalone/primary64.h
  compiler-rt/lib/scudo/standalone/stats.h
  compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp
  compiler-rt/lib/scudo/standalone/wrappers_c.inc
  libcxx/include/__config
  libcxx/include/__threading_support
  libcxx/include/memory
  libcxx/include/mutex
  libcxx/include/thread
  libcxx/src/mutex.cpp
  libcxx/test/std/utilities/time/time.cal/time.cal.day/time.cal.day.nonmembers/literals.pass.cpp
  libcxx/test/std/utilities/time/time.cal/time.cal.year/time.cal.year.nonmembers/literals.pass.cpp
  libcxxabi/include/__cxxabi_config.h
  lld/ELF/SymbolTable.cpp
  lld/ELF/Symbols.h
  lld/ELF/SyntheticSections.cpp
  lld/MinGW/Options.td
  lld/test/ELF/silent-ignore.test
  lld/test/MinGW/driver.test
  lldb/cmake/modules/LLDBConfig.cmake
  lldb/include/lldb/Host/common/NativeProcessProtocol.h
  lldb/lit/Minidump/Windows/Inputs/find-module.dmp.yaml
  lldb/lit/Minidump/Windows/Inputs/find-module.exe.yaml
  lldb/lit/Minidump/Windows/find-module.test
  lldb/packages/Python/lldbsuite/test/dotest.py
  lldb/packages/Python/lldbsuite/test/lldbtest.py
  lldb/packages/Python/lldbsuite/test/python_api/interpreter/TestCommandInterpreterAPI.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteKill.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteProcessInfo.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteSingleStep.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vCont.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/commandline/TestStubSetSID.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/inferior-crash/TestGdbRemoteSegFault.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/register-reading/main.cpp
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/signal-filtering/TestGdbRemote_QPassSignals.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py
  lldb/source/API/SBCommandReturnObject.cpp
  lldb/source/Host/windows/Host.cpp
  lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
  lldb/source/Plugins/Process/Utility/CMakeLists.txt
  lldb/source/Plugins/Process/Utility/RegisterContextWindows_i386.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextWindows_i386.h
  lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.h
  lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
  lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
  lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
  lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.h
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.h
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.h
  lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp
  lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.h
  lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/third_party/Python/module/unittest2/unittest2/case.py
  lldb/tools/lldb-server/lldb-gdbserver.cpp
  lldb/tools/lldb-server/lldb-platform.cpp
  lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp
  lldb/unittests/tools/lldb-server/tests/TestBase.h
  lldb/unittests/tools/lldb-server/tests/TestClient.cpp
  llvm/cmake/modules/CheckCompilerVersion.cmake
  llvm/cmake/modules/HandleLLVMOptions.cmake
  llvm/docs/CodingStandards.rst
  llvm/docs/Coroutines.rst
  llvm/docs/GettingStarted.rst
  llvm/docs/LangRef.rst
  llvm/examples/SpeculativeJIT/SpeculativeJIT.cpp
  llvm/include/llvm/BinaryFormat/Magic.h
  llvm/include/llvm/CodeGen/GlobalISel/MIPatternMatch.h
  llvm/include/llvm/CodeGen/MachineRegisterInfo.h
  llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
  llvm/include/llvm/IR/DiagnosticInfo.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/Object/ELFObjectFile.h
  llvm/include/llvm/Object/ObjectFile.h
  llvm/include/llvm/Support/GenericDomTree.h
  llvm/include/llvm/Support/type_traits.h
  llvm/include/llvm/Transforms/Utils/LoopUtils.h
  llvm/lib/BinaryFormat/Magic.cpp
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/lib/CodeGen/MachineCopyPropagation.cpp
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
  llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
  llvm/lib/ExecutionEngine/JITLink/MachOAtomGraphBuilder.cpp
  llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
  llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
  llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp
  llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFX86_64.h
  llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h
  llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOI386.h
  llvm/lib/IR/Constants.cpp
  llvm/lib/Object/Binary.cpp
  llvm/lib/Object/COFFObjectFile.cpp
  llvm/lib/Object/Decompressor.cpp
  llvm/lib/Object/ELFObjectFile.cpp
  llvm/lib/Object/MachOObjectFile.cpp
  llvm/lib/Object/Object.cpp
  llvm/lib/Object/ObjectFile.cpp
  llvm/lib/Object/SymbolicFile.cpp
  llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64RegisterBankInfo.cpp
  llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/lib/Target/PowerPC/PPCISelLowering.h
  llvm/lib/Target/PowerPC/PPCInstrFormats.td
  llvm/lib/Target/PowerPC/PPCInstrInfo.td
  llvm/lib/Target/PowerPC/PPCInstrVSX.td
  llvm/lib/Target/PowerPC/PPCSubtarget.h
  llvm/lib/Target/PowerPC/PPCTOCRegDeps.cpp
  llvm/lib/Target/PowerPC/PPCTargetMachine.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86TargetTransformInfo.cpp
  llvm/lib/Transforms/Coroutines/CoroCleanup.cpp
  llvm/lib/Transforms/Coroutines/CoroEarly.cpp
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp
  llvm/lib/Transforms/Coroutines/CoroInstr.h
  llvm/lib/Transforms/Coroutines/CoroInternal.h
  llvm/lib/Transforms/Coroutines/CoroSplit.cpp
  llvm/lib/Transforms/Coroutines/Coroutines.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/lib/Transforms/InstCombine/InstCombineInternal.h
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp
  llvm/lib/Transforms/Utils/BuildLibCalls.cpp
  llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/lib/XRay/InstrumentationMap.cpp
  llvm/test/Analysis/CostModel/X86/cast.ll
  llvm/test/Analysis/CostModel/X86/extend.ll
  llvm/test/Analysis/CostModel/X86/min-legal-vector-width.ll
  llvm/test/Analysis/CostModel/X86/shuffle-extract_subvector.ll
  llvm/test/Analysis/TypeBasedAliasAnalysis/memcpyopt.ll
  llvm/test/Bitcode/upgrade-memory-intrinsics.ll
  llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir
  llvm/test/CodeGen/AArch64/GlobalISel/regbankselect-unmerge-vec.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-shuffle-vector.mir
  llvm/test/CodeGen/MIR/X86/pr38773.mir
  llvm/test/CodeGen/Mips/blockaddr.ll
  llvm/test/CodeGen/Mips/global-address.ll
  llvm/test/CodeGen/PowerPC/aix_fpr_param.ll
  llvm/test/CodeGen/PowerPC/build-vector-allones.ll
  llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix.ll
  (113 more files...)