[Lldb-commits] [PATCH] D66370: [dotest] Add a dotest flag `--force-dwarf` to override the tested DWARF version.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 16 16:22:37 PDT 2019


aprantl added a comment.

This is definitely more elegant than the current solution!



================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:353
+
+    os.environ['CFLAGS_EXTRAS'] = cflags_extras
 
----------------
Does this actually work with tests whose Makefiles manually set CFLAGS_EXTRAS? I.e., do we need to distinguish between extra CFLAGS that come in from the layer above and ones that are meant to be customized in the individual test Makefiles?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66370/new/

https://reviews.llvm.org/D66370





More information about the lldb-commits mailing list