[Lldb-commits] [PATCH] D66331: Save / restore selected platform in tests that may change it

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 16 01:23:57 PDT 2019


labath added a comment.

> I'm not sure if fixing this on a test-by-test basis is the right place for it. It might be better to have dotest.py's run_suite() save the remote platform and lldbtest.py's class Base setUpClass() method re-set the platform before the test is invoked, in case it was mutated during a test run.

Yeah, I was thinking the same thing. I think that, at this point, we have enough tests needs things like this that a more general solution is justified.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66331/new/

https://reviews.llvm.org/D66331





More information about the lldb-commits mailing list