[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 4 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Utility/RegularExpression.h:98
+  /// The compiled regular expression.
+  mutable llvm::Regex m_regex;
 };
----------------
clayborg wrote:
> Why does this need to be mutable?
`llvm::Regex`'s match method is not const. We could unconst  `Execute` but that would mean a bunch of churn in the API. 


================
Comment at: lldb/source/Commands/CommandObjectFrame.cpp:1
-//===-- CommandObjectFrame.cpp ----------------------------------*- C++ -*-===//
+//===-- CommandObrectFrame.cpp ----------------------------------*- C++ -*-===//
 //
----------------
clayborg wrote:
> revert
Oops


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66174/new/

https://reviews.llvm.org/D66174