[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

[Jim Ingham via lldb-commits]

Ah, that's just from the template test's Makefile, which I constructed by cribbing from a bunch of other tests which all did that.  It probably isn't always necessary, but shouldn't do any harm either.

Jim


> On Aug 14, 2019, at 2:31 PM, Davide Italiano via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> davide added inline comments.
> 
> 
> ================
> Comment at: packages/Python/lldbsuite/test/functionalities/stop-hooks/Makefile:4
> +C_SOURCES := main.c
> +CFLAGS_EXTRAS += -std=c99
> +
> ----------------
> jingham wrote:
>> davide wrote:
>>> Forgive my ignorance, but why you need this?
>> That's how the dotest tests know what to build.
> I understand `C_SOURCES`, but do you need to specify also the standard? That seems redundant, but I might be missing something [mainly asking for my education].
> 
> 
> Repository:
>  rLLDB LLDB
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D66241/new/
> 
> https://reviews.llvm.org/D66241
> 
> 
>