[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 215248.
JDevlieghere marked 7 inline comments as done.
JDevlieghere added a comment.
Herald added a subscriber: mgorny.

- Cleanup interface
- Return llvm::Error
- Remove size comparison
- Add empty regex workaround
- Add unit tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66174/new/

https://reviews.llvm.org/D66174

Files:
  lldb/include/lldb/Interpreter/OptionValueRegex.h
  lldb/include/lldb/Utility/RegularExpression.h
  lldb/source/Commands/CommandObjectBreakpoint.cpp
  lldb/source/Commands/CommandObjectFrame.cpp
  lldb/source/Core/Disassembler.cpp
  lldb/source/Host/common/Socket.cpp
  lldb/source/Interpreter/CommandObjectRegexCommand.cpp
  lldb/source/Interpreter/OptionArgParser.cpp
  lldb/source/Interpreter/OptionValueRegex.cpp
  lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
  lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
  lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
  lldb/source/Symbol/ObjectFile.cpp
  lldb/source/Symbol/Variable.cpp
  lldb/source/Target/ThreadPlanStepInRange.cpp
  lldb/source/Utility/RegularExpression.cpp
  lldb/unittests/Utility/CMakeLists.txt
  lldb/unittests/Utility/RegularExpressionTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66174.215248.patch
Type: text/x-patch
Size: 41546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190814/7b4cd9be/attachment-0001.bin>