[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Aug 14 13:57:32 PDT 2019
aprantl added inline comments.
================
Comment at: source/Symbol/ClangASTContext.cpp:1505
- bool is_anonymous = (!name) || (!name[0]);
+ bool has_name = (!name) || (!name[0]);
----------------
aprantl wrote:
> aprantl wrote:
> > The condition needs to be reversed now to match the new name.
> `bool has_name = (name && name[0])`
Even more elegant would be changing the function to take a StringRef, but you don't have to do that....
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66175/new/
https://reviews.llvm.org/D66175
More information about the lldb-commits
mailing list