[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: source/Symbol/ClangASTContext.cpp:1509
       *ast, (TagDecl::TagKind)kind, decl_ctx, SourceLocation(),
       SourceLocation(), is_anonymous ? nullptr : &ast->Idents.get(name));
 
----------------
aprantl wrote:
> `has_name ? &ast->Idents.get(name) : nullptr`
and then here, too.


================
Comment at: source/Symbol/ClangASTContext.cpp:1505
 
-  bool is_anonymous = (!name) || (!name[0]);
+  bool has_name = (!name) || (!name[0]);
 
----------------
The condition needs to be reversed now to match the new name.


================
Comment at: source/Symbol/ClangASTContext.cpp:1516
+    // struct A {
+    //  // anonymous class
+    //  struct {
----------------
 // anonymous class (GNU/MSVC extension)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66175/new/

https://reviews.llvm.org/D66175