[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: source/Symbol/ClangASTContext.cpp:1521
+    //
+    // This fix will unfortunately still mislabel unnamed classes within a class
+    // but this improves the situation greatly since getting this wrong in the
----------------
// FIXME: An unnamed class within a class is also wrongly recognized as an anonymous struct.


================
Comment at: source/Symbol/ClangASTContext.cpp:1524
+    // other cases can lead to an assert in clang CodeCompletion since
+    // SemaAccess assumes the DeclContext of an anonymous class is a
+    // CXXRecordDecl.
----------------
and move the excuse in the commit message.

It would be really helpful though to include tiny source code examples here to iiustrate the difference between unnames struct and anonymous structs vs. unnamed structs in structs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66175/new/

https://reviews.llvm.org/D66175