[Lldb-commits] [lldb] r368695 - [lldb] Fix Microsoft guard variable detection
Raphael Isemann via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 13 07:13:39 PDT 2019
Author: teemperor
Date: Tue Aug 13 07:13:39 2019
New Revision: 368695
URL: http://llvm.org/viewvc/llvm-project?rev=368695&view=rev
Log:
[lldb] Fix Microsoft guard variable detection
Apparently we need to check for a suffix, not a prefix. This broke
probably broke expression evaluation on Windows.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp?rev=368695&r1=368694&r2=368695&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp (original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Tue Aug 13 07:13:39 2019
@@ -160,7 +160,7 @@ static bool isGuardVariableSymbol(llvm::
bool check_ms_abi = true) {
bool result = mangled_symbol.startswith("_ZGV"); // Itanium ABI guard variable
if (check_ms_abi)
- result |= mangled_symbol.startswith("@4IA"); // Microsoft ABI
+ result |= mangled_symbol.endswith("@4IA"); // Microsoft ABI
return result;
}
More information about the lldb-commits
mailing list