[Lldb-commits] [lldb] r368582 - [lldb][NFC] Minor fixes for lldb_private::DiagnosticManager

[Raphael Isemann via lldb-commits]

Author: teemperor
Date: Mon Aug 12 07:37:12 2019
New Revision: 368582

URL: http://llvm.org/viewvc/llvm-project?rev=368582&view=rev
Log:
[lldb][NFC] Minor fixes for lldb_private::DiagnosticManager

Modified:
    lldb/trunk/include/lldb/Expression/DiagnosticManager.h

Modified: lldb/trunk/include/lldb/Expression/DiagnosticManager.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/DiagnosticManager.h?rev=368582&r1=368581&r2=368582&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Expression/DiagnosticManager.h (original)
+++ lldb/trunk/include/lldb/Expression/DiagnosticManager.h Mon Aug 12 07:37:12 2019
@@ -106,7 +106,7 @@ public:
     }
   }
 
-  bool HasFixIts() {
+  bool HasFixIts() const {
     for (Diagnostic *diag : m_diagnostics) {
       if (diag->HasFixIts())
         return true;
@@ -130,9 +130,8 @@ public:
   void PutString(DiagnosticSeverity severity, llvm::StringRef str);
 
   void AppendMessageToDiagnostic(llvm::StringRef str) {
-    if (!m_diagnostics.empty()) {
+    if (!m_diagnostics.empty())
       m_diagnostics.back()->AppendMessage(str);
-    }
   }
 
   // Returns a string containing errors in this format:
@@ -149,7 +148,6 @@ public:
   // Moves fixed_expression to the internal storage.
   void SetFixedExpression(std::string fixed_expression) {
     m_fixed_expression = std::move(fixed_expression);
-    fixed_expression.clear();
   }
 
 protected: