[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/include/lldb/Core/FileSpecList.h:29
+  typedef std::vector<FileSpec> collection;
+  typedef collection::iterator iterator;
+  typedef collection::const_iterator const_iterator;
----------------
JDevlieghere wrote:
> grimar wrote:
> > Seems you don't use `iterator` anywhere?
> It's used in the range-based for loop in `ParseSupportFiles`
Technically I think these typedefs should use LLDB style

using Collection = std::vector<FileSpec>; / typedef std::vector<FileSpec> Collection.

Though not the const_iterator, that would be silly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62570/new/

https://reviews.llvm.org/D62570