[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 8 07:30:11 PDT 2019


labath created this revision.
labath added reviewers: clayborg, JDevlieghere, jingham.
Herald added subscribers: MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.

This is the last patch in the SymbolVendor series. Now that the symbol
vendors don't do anything, we can avoid creating their instances
completely, and just return SymbolFiles directly, removing a lot of
boilerplate in the process.

SymbolVendors still remain responsible for finding symbol files, and I've
updated all the comments I could find to reflect that.


https://reviews.llvm.org/D65952

Files:
  include/lldb/Core/Module.h
  include/lldb/Core/PluginManager.h
  include/lldb/Symbol/SymbolVendor.h
  include/lldb/lldb-private-interfaces.h
  source/Core/Module.cpp
  source/Core/PluginManager.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
  source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
  source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
  source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h
  source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
  source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h
  source/Symbol/SymbolContext.cpp
  source/Symbol/SymbolVendor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65952.214150.patch
Type: text/x-patch
Size: 40136 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190808/4c291195/attachment-0001.bin>


More information about the lldb-commits mailing list