[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I'm not very familiar with this code, so I don't really understand what kind of rewriting it does, or what is this metadata thing, but...... what if we turn this around somehow? What are the circumstances under which we don't find metadata for a global variable and we definitely *do* want to report this as an error?

Are there any, or is this just some kind of a sanity check on the inner workings of the expression parser machinery? I tried replacing the bit of code which currently special cases objc selectors and variables without external linkage (and now RTTI info) with just an unconditional "true", and nothing spectacular seems to happen -- all of the tests pass (including the one you've just added). If we can fix tests by deleting code, then I would prefer we do that instead of introducing more dubious code...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65932/new/

https://reviews.llvm.org/D65932