[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 7 23:51:01 PDT 2019


labath added a comment.

>From the looks of it, this appears to be the offset in the data extractor that you want to start extracting from (so, e.g. if you have a large data extractor, and you know that the value you're interested in is at byte 47, you would say `GetValueAsData(large_extractor, 47)`.

That said, I think it would be good to remove this, as it does not seem to be a common use case, and one can always create a sub-data extractor, if he really wants to start extracting from a random offset.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65910/new/

https://reviews.llvm.org/D65910





More information about the lldb-commits mailing list