[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 7 15:54:12 PDT 2019


aprantl created this revision.
aprantl added reviewers: jingham, clayborg, labath, jasonmolenda.
Herald added a project: LLDB.
aprantl updated this revision to Diff 214024.

Value::GetValueAsData() takes an undocumented parameter called data_offset that is always 0. I couldn't figure out what it is supposed to be used for and it is never used, so here's a patch to remove it.


https://reviews.llvm.org/D65910

Files:
  lldb/include/lldb/Core/Value.h
  lldb/source/Core/Value.cpp
  lldb/source/Core/ValueObject.cpp
  lldb/source/Core/ValueObjectCast.cpp
  lldb/source/Core/ValueObjectChild.cpp
  lldb/source/Core/ValueObjectConstResult.cpp
  lldb/source/Core/ValueObjectDynamicValue.cpp
  lldb/source/Core/ValueObjectMemory.cpp
  lldb/source/Core/ValueObjectSyntheticFilter.cpp
  lldb/source/Core/ValueObjectVariable.cpp
  lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65910.214024.patch
Type: text/x-patch
Size: 9201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190807/dfd4acd2/attachment-0001.bin>


More information about the lldb-commits mailing list