[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked 3 inline comments as done.
teemperor added a comment.

- Moved from macro to source file name filtering. No longer enable the tests with this patch as we still have the include path bug to fix.



================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:141
+    // loaded by the user. We can stop here as we only care about user-loaded
+    // modules.
+    if (!m_entered_expr)
----------------
aprantl wrote:
> Just to make sure I'm understanding:
> 
> `expr @import Foo` will still work, but it will import Foo into the expression rather than into the context from which we ASTImport definitions?
Yeah, we only filter our own generated imports that are non-permanent and only for one expression.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61565/new/

https://reviews.llvm.org/D61565