[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 6 10:10:39 PDT 2019
jingham added inline comments.
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55
#define PATH_MAX MAX_PATH
typedef int socklen_t;
> amccarth wrote:
> > hhb wrote:
> > > amccarth wrote:
> > > > Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the `#define` instead of executing it conditionally.
> > > PATH_MAX is used in SendProcessEvent (line 283)
> > Got it. When I asked Phabricator to show me all the lines, it didn't show me _all_ the lines.
> > That said, it seems unfortunate that it's yet another fixed-length filename buffer instead of getting a ConstString from the FileSpec. But that's outside the scope of this change.
> The problem is that you're dealing with the SBFileSpec here, and that makes things slightly complicated (stable api, not being able to return c++ objects through it, etc...).
There's no reason we couldn't add an SBString class to vend non-fixed length strings. There haven't been enough instances where we really needed it to motivate that, but we have SBStringList to wrap vectors of strings, so it wouldn't be out of place.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits