[Lldb-commits] [PATCH] D65797: [lldb][CMake] Generating Xcode projects

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 6 08:51:21 PDT 2019


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Small comment about the working, but the change itself LGTM.



================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:77
+    message(WARNING
+      "When building with Xcode, please use the corresponding cache script. "
+      "Clean your build directory and re-run CMake with:\n"
----------------
[bikeshedding] I think we should say something like:

> When building with Xcode, we recommend using the corresponding cache script. If this was a mistake, clean your lean your build directory and re-run CMake with:




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65797/new/

https://reviews.llvm.org/D65797





More information about the lldb-commits mailing list