[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW
Adrian McCarthy via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 5 15:20:41 PDT 2019
amccarth marked an inline comment as done.
amccarth added inline comments.
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55
#define PATH_MAX MAX_PATH
typedef int socklen_t;
> amccarth wrote:
> > Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the `#define` instead of executing it conditionally.
> PATH_MAX is used in SendProcessEvent (line 283)
Got it. When I asked Phabricator to show me all the lines, it didn't show me _all_ the lines.
That said, it seems unfortunate that it's yet another fixed-length filename buffer instead of getting a ConstString from the FileSpec. But that's outside the scope of this change.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits