[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW
Adrian McCarthy via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 5 08:59:40 PDT 2019
amccarth added a comment.
Yes, zturner isn't as active here as he was before.
I'm happy to review patches regarding LLDB on Windows, even though I don't know much about Mingw.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:19
> Maybe drop usleep and use C++’s
> https://en.cppreference.com/w/cpp/thread/sleep_for ?
+1. usleep is deprecated in POSIX and is essentially meaningless on Windows (in terms of how the scheduler works) unless you're waiting 1000 or more microseconds. At this point, sleep_for is likely to be better supported by the platforms.
Comment at: lldb/tools/lldb-vscode/VSCode.cpp:19
I would suggest moving the `#ifndef __MINGW32__` up a line to keep the NOMINMAX adjacent to the include of Windows.h. NOMINMAX is relevant only to Windows.h.
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55
#define PATH_MAX MAX_PATH
typedef int socklen_t;
Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the `#define` instead of executing it conditionally.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits