[Lldb-commits] [PATCH] D65647: Fix line table resolution near the end of a section

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 5 06:12:10 PDT 2019


labath updated this revision to Diff 213342.
labath added a comment.
Herald added a reviewer: jdoerfert.

- redo the patch to keep the logic inside the line table code. I've been

considering whether to do that my self. On one hand, this functionality seems
like it could be useful in other places, but OTOH, the bool argument api is not
really nice. I guess we can keep it this way until we come up with a better way
to do that.

I've kept the module unit test as it seems useful regardless of the fact that
I'm not changing that code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65647/new/

https://reviews.llvm.org/D65647

Files:
  lit/SymbolFile/DWARF/debug-line-basic.s
  lit/SymbolFile/DWARF/dir-separator-no-comp-dir-relative-name.s
  lit/SymbolFile/DWARF/dir-separator-no-comp-dir.s
  lit/SymbolFile/DWARF/dir-separator-posix.s
  lit/SymbolFile/DWARF/dir-separator-windows.s
  source/Symbol/LineTable.cpp
  unittests/Core/CMakeLists.txt
  unittests/Core/Inputs/resolve-file-address.yaml
  unittests/Core/ModuleTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65647.213342.patch
Type: text/x-patch
Size: 9091 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190805/379f7fd8/attachment.bin>


More information about the lldb-commits mailing list