[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Aug 2 07:17:02 PDT 2019
mgorny marked an inline comment as done.
mgorny added inline comments.
================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737
+ for (auto it = m_threads.begin(); it != m_threads.end(); ++it) {
+ if (*it && ((*it)->GetID() == thread_id)) {
+ m_threads.erase(it);
----------------
labath wrote:
> It looks like the rest of the code assumes (as I think it should) that the thread list does not contain null pointers. See e.g. the loop on line 276.
For the record, I've copied it from Linux ;-P.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65555/new/
https://reviews.llvm.org/D65555
More information about the lldb-commits
mailing list