[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 2 00:25:18 PDT 2019

labath added a comment.

> Are you accepting this review?

No I would still like to see the two comments I made in <D63165#1607877 <https://reviews.llvm.org/D63165#1607877>> to be addressed. The last comment was just acknowledging the fact that you (or is it @Hui? I'm not sure who actually writes these patches...) were following the existing pattern in the linux register contexts. However, the pattern over there is for a reason, and that reason does not apply here. That doesn't make the linux code less ugly (probably the opposite), but it does mean we shouldn't try to emulate it if there are better options available...



More information about the lldb-commits mailing list