jingham added a comment. What happens if you clang-format your reformatted version of the setter? Do we need clang-format off for them? Otherwise this looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65489/new/ https://reviews.llvm.org/D65489