[Lldb-commits] [PATCH] D65569: Remove SymbolVendor::GetSymtab

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 1 03:54:27 PDT 2019


labath created this revision.
labath added reviewers: clayborg, JDevlieghere, jingham.

This patch removes the GetSymtab method from the SymbolVendor, which is
a no-op as it's implementation just forwards to the relevant SymbolFile.
Instead it creates a Module::GetSymtab, which calls the SymbolFile
method directly.

All callers have been updated to use the Module method directly instead
of a two phase GetSymbolVendor->GetSymtab search, which leads to reduced
intentation in a lot of deeply nested code.


https://reviews.llvm.org/D65569

Files:
  include/lldb/Core/Module.h
  include/lldb/Symbol/SymbolVendor.h
  source/API/SBModule.cpp
  source/Commands/CommandObjectTarget.cpp
  source/Core/Address.cpp
  source/Core/Module.cpp
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp
  source/Symbol/SymbolFile.cpp
  source/Symbol/SymbolVendor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65569.212776.patch
Type: text/x-patch
Size: 14603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190801/df06477c/attachment-0001.bin>


More information about the lldb-commits mailing list