[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: jankratochvil, mgorny, clayborg.
Herald added subscribers: MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.

The debug link and build-id lookups are two independent ways one can
search for a separate symbol file. However, our implementation in
SymbolVendorELF was tying the two together and refusing to look up the
symbol file based on a build id if the file did not contain a debug
link.

This patch makes it possible to search for the symbol file with
just one of the two methods available. To demonstrate, I split the
build-id-case test into two, so that we test the search using both
methods.


https://reviews.llvm.org/D65561

Files:
  lit/Modules/ELF/build-id-case.yaml
  lit/Modules/ELF/gnu-debuglink.yaml
  source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
  source/Symbol/LocateSymbolFile.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65561.212751.patch
Type: text/x-patch
Size: 10686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190801/c0100a2a/attachment.bin>