[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 31 06:28:36 PDT 2019
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just add a few null checks and this will be good to go.
================
Comment at: source/Commands/CommandObjectTarget.cpp:2240
Module *m = target->GetImages().GetModulePointerAtIndex(image_idx);
- SymbolFile *sf = m->GetSymbolVendor()->GetSymbolFile();
- sf->DumpClangAST(result.GetOutputStream());
+ m->GetSymbolFile()->DumpClangAST(result.GetOutputStream());
}
----------------
check m->GetSymbolFile() for NULL
================
Comment at: source/Commands/CommandObjectTarget.cpp:2265
Module *m = module_list.GetModulePointerAtIndex(i);
- SymbolFile *sf = m->GetSymbolVendor()->GetSymbolFile();
- sf->DumpClangAST(result.GetOutputStream());
+ m->GetSymbolFile()->DumpClangAST(result.GetOutputStream());
}
----------------
check m->GetSymbolFile() for NULL
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65435/new/
https://reviews.llvm.org/D65435
More information about the lldb-commits
mailing list