[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

JF Bastien via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 29 21:02:40 PDT 2019


jfb added a comment.

In D65249#1605523 <https://reviews.llvm.org/D65249#1605523>, @rnk wrote:

> I have concerns that some of the patches that you landed prior to this will cause issues with old versions of MSVC, but in isolation, this is fine, and if anyone complains, we can address it on a case-by-case basis. lgtm


IIUC Billy correctly, the issue was just with `aligned_storage`, but if you roll your own (as I have) we're fine. If I'm wrong, these tests will fail on MSVC bots :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65249/new/

https://reviews.llvm.org/D65249





More information about the lldb-commits mailing list