[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 29 11:13:56 PDT 2019


clayborg added a comment.

So previously the SymbolVendor would only make a strong reference to the object file if it didn't match the object file of the module. Now it always makes one. Might be ok since the Module owns the SymbolVendor and thus owns the SymbolFile. We should make sure we don't end up keeping an object file alive when a module goes away due to multiple strong references. I am guessing it will be ok, but good to verify.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65401/new/

https://reviews.llvm.org/D65401





More information about the lldb-commits mailing list