[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

Mon Jul 29 08:41:12 PDT 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.

BTW, I was pretty much a python noob too when starting with lldb, but our test suite has forced me to become somewhat of an expert. :)

================
Comment at: lldb/tools/lldb-test/lldb-test.cpp:979
   ModuleList::GetGlobalModuleListProperties().SetEnableExternalLookup(false);
+  // There is no SB API for settings in general like:
+  // GetGlobalPluginProperties()->SetPacketTimeout(std::chrono::seconds(60));
----------------
lldb-test is not confined by the SB API. The reason this (unlike the `symbols.enable-external-lookup` thingy) does not work is because ProcessGDBRemote is a plugin, and so the API to access the setting is hidden by the plugin encapsulation...

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65271/new/

https://reviews.llvm.org/D65271