[Lldb-commits] [PATCH] D65353: [lldb] Also include the array definition in Properties.inc

Mon Jul 29 07:37:10 PDT 2019

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM beside a small nit pick.

================
Comment at: lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp:150
   OS << "#ifdef " << NeededMacro << "\n";
+  // OS << "enum {\n";
   for (Record *R : PropertyRecords)
----------------
Is this like a placeholder for supporting enums? I think a FIXME or TODO would be more appropriate. (Feel free to ignore this if you already have a patch lined up for enums and this will be instantly overwritten)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65353/new/

https://reviews.llvm.org/D65353