[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

Fri Jul 26 13:55:20 PDT 2019

jfb added a subscriber: BillyONeal.
jfb added a comment.

In D65249#1603133 <https://reviews.llvm.org/D65249#1603133>, @rnk wrote:

> I still think this concern applies:
>  https://reviews.llvm.org/D64417#1576675
>
> I'm not sure how to track down an 19.11 release to test if we can pass std::aligned_storage values through function calls on x86. We might be better off raising the minimum to 19.14, which is a more recent MSVC release in the 2017 track. I don't think it's too much to ask developers to use the most recent version of the 2017 compiler, they won't have to change IDEs.

@BillyONeal do you know if 19.11 has the `aligned_storage` issue on x86?

If it does then indeed we should raise the minimum version, I'll send an RFC.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65249/new/

https://reviews.llvm.org/D65249