[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.


================
Comment at: lldb/docs/resources/build.rst:94
+project, it generates the files needed by your build tool. The recommended
+build tool for LLVM is Ninja. Please also read `Building LLVM with CMake
+<http://llvm.org/docs/CMake.html>`_.
----------------
sgraenitz wrote:
> stella.stamenova wrote:
> > Is Ninja the recommended build tool on Windows as well?
> Well it's recommended for LLVM and I used it for LLDB on Windows in the past.
> Maybe @zturner knows more about it?
LLDB does build with both Ninja and VS on Windows. I don't know that either one is "recommended" though and we usually build with VS.


================
Comment at: lldb/docs/resources/build.rst:105
+
+  > cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;lldb" [<cmake options>] path/to/llvm-project/llvm
+
----------------
sgraenitz wrote:
> stella.stamenova wrote:
> > I thought some of the tests need lld as well
> So far, the documentation didn't mention lld. I would recommend using lld to **build** LLDB on Linux, but AFAIK it's not required to build lld along with LLDB.
For example, lldb\lit\SymbolFile\DWARF\debug-types-basic.test contains this:

# REQUIRES: lld

There are other tests as well that require lld.


================
Comment at: lldb/docs/resources/build.rst:235
+
+  > cmake -G "Visual Studio 14 2015" <cmake variables> <path to root of llvm source tree>
+
----------------
sgraenitz wrote:
> stella.stamenova wrote:
> > We retired VS2015 support
> What generator string would you like to see here instead? (So far I just kept what was there.)
cmake -G "Visual Studio 15 2017 Win64" -Thost=x64


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65330/new/

https://reviews.llvm.org/D65330