[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

[Marshall Clow via Phabricator via lldb-commits]

mclow.lists added inline comments.
Herald added a project: LLVM.


================
Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:77
+  const char *swift_clang_resource_dir = "usr/lib/swift/clang";
+  auto parent = std::next(rev_it);
+  if (parent != r_end && *parent == "SharedFrameworks") {
----------------
This line fails to build on my old Mac Pro (Mac OS X 10.11, apple-clang-8), complaining that `std::next` requires a forward iterator, and `rev_it` is not one.

changing this code to:
```
auto parent = rev_it;
std::advance(parent, 1);
```
fixes the compile error.

Note that these are the most recent OS and tools for this computer.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47384/new/

https://reviews.llvm.org/D47384