[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.


================
Comment at: lldb/docs/resources/build.rst:94
+project, it generates the files needed by your build tool. The recommended
+build tool for LLVM is Ninja. Please also read `Building LLVM with CMake
+<http://llvm.org/docs/CMake.html>`_.
----------------
Is Ninja the recommended build tool on Windows as well?


================
Comment at: lldb/docs/resources/build.rst:105
+
+  > cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;lldb" [<cmake options>] path/to/llvm-project/llvm
+
----------------
I thought some of the tests need lld as well


================
Comment at: lldb/docs/resources/build.rst:235
+
+  > cmake -G "Visual Studio 14 2015" <cmake variables> <path to root of llvm source tree>
+
----------------
We retired VS2015 support


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65330/new/

https://reviews.llvm.org/D65330