[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

Fri Jul 26 09:42:18 PDT 2019

amccarth added a comment.

In D65230#1602370 <https://reviews.llvm.org/D65230#1602370>, @labath wrote:

> Thanks.
>
> BTW, I tried this on windows, and it didn't blow up in my face, I think it should be relatively safe. I couldn't reproduce the problems that @amccarth was experiencing, so I don't know if it fixes that problem. It would be good to know whether it does, as we could cherry-pick this to the release branch in that case.

Sorry for the slow reply.  I've been in a conference most of the week.

Since my problem tends to be a "just me" problem that doesn't affect the bots or apparently anyone else, I don't think a cherrypick is necessary.

By having only one version of Python on my machine, I was able to work around that problem.  Unfortunately, I've been stuck on another problem since making that change (specifically, all dotest.py tests report "Python memory allocator called without holding the GIL" and crash).  This, too, seems to be a "just me" thing, and I'm continuing to work on that this morning.  Until I get that figured out, I don't think I want to perturb my environment further by re-installing a second version of Python.  I suspect the other patch to eliminate multiprocessing from dotest.py might solve the GIL problem as well, but I want to know more first.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65230/new/

https://reviews.llvm.org/D65230