[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

Fri Jul 26 00:47:11 PDT 2019

labath added a comment.

In D65271#1601717 <https://reviews.llvm.org/D65271#1601717>, @jankratochvil wrote:

> In D65271#1600829 <https://reviews.llvm.org/D65271#1600829>, @labath wrote:
>
> > Why not unify now? It shouldn't be too hard to at least unify all the instances in dotest python code to a single place. That would already cut the number of places that need to be kept synced in half...
>
>
> Done; but I do not like much that `from lldbsuite.test.lldbtest import Base` in `vscode.py` but then other choices (passing `Base.setUpCommands()` from callers) looks even more messy to me.

I think I'd go for threading it in from VSCodeTestCaseBase. Maybe not as an argument to `request_attach` and friends, but possibly as an argument to the `DebugCommunication` object constructor.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65271/new/

https://reviews.llvm.org/D65271