[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jul 25 19:52:59 PDT 2019
xiaobai added a comment.
After going through this and modifying this patch, I can't help but wonder if `llvm::Optional<TypeSystem &>` would be more appropriate. There are plenty of instances where it's not a hard error if you can't get a TypeSystem and the appropriate action is probably just to log and move on. I am conflicted because I like how Expected forces you to be more rigorous with error handling but I can't help but feel it is the wrong abstraction. Thoughts?
CHANGES SINCE LAST ACTION
More information about the lldb-commits