[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1874-1875
 
-    ConstString Name(("PT_LOAD[" + llvm::Twine(LoadID++) + "]").str());
+    ConstString Name(llvm::formatv("{0}[{1}]", provider.GetSegmentName(),
+                                   provider.GetSegmentCount())
+                         .str());
----------------
Maybe ask segment provider to get the next segment name?

```
ConstString Name(provider.GetNextSegmentName());
```

And have the llvm::formatv call be in a the VMAddressProvider::GetNextSegmentName()?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65282/new/

https://reviews.llvm.org/D65282