[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil created this revision.
jankratochvil added reviewers: aprantl, labath, clayborg.
jankratochvil added a project: LLDB.
Herald added subscribers: lldb-commits, abidh.

rL357954 <https://reviews.llvm.org/rL357954> did increase `packet-timeout` 1sec -> 5secs. Which is IMO about the maximum timeout reasonable for regular use. But for testsuite I think the timeout should be higher as the testsuite runs in parallel and it can be run even on slow hosts and with other load (moreover if it runs on some slow arch).
I have chosen 300 secs, I do not mind lower but it should be >=60 I think.
I agree these testsuite settings together with `symbols.enable-external-lookup` should be unified to a single place but that can be some other patch.
This patch was based on this testsuite timeout:
http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/546/steps/test/logs/stdio

  FAIL: test_connect (TestGDBRemoteClient.TestGDBRemoteClient)
     Test connecting to a remote gdb server
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/jkratoch/slave-lldb-x86_64-fedora/lldb-x86_64-fedora/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py", line 13, in test_connect
      process = self.connect(target)
    File "/home/jkratoch/slave-lldb-x86_64-fedora/lldb-x86_64-fedora/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py", line 480, in connect
      self.assertTrue(error.Success(), error.description)
  AssertionError: False is not True : failed to get reply to handshake packet


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D65271

Files:
  lldb/lit/lit-lldb-init.in
  lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template
  lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoWatchpointSupportInfo.py
  lldb/packages/Python/lldbsuite/test/lldbtest.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/tools/lldb-test/lldb-test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65271.211711.patch
Type: text/x-patch
Size: 5256 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190725/11ed9d04/attachment-0001.bin>