[Lldb-commits] [PATCH] D65208: SymbolVendor: Move Symtab construction into the SymbolFile

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 25 01:00:38 PDT 2019


labath added a comment.

In D65208#1599648 <https://reviews.llvm.org/D65208#1599648>, @clayborg wrote:

> So the original idea behind the symbol vendor was that if you have more than one binary: stripped installed binary, and unstripped debug info binary with symbols, that the symbol table could be generated by using one or more object files. It would be nice to ensure we can still do this somehow.


This functionality still exists/works (we even have tests for it :P), and I have no intention of removing it. The merging of sections from the split binaries happens in SymbolVendorELF::CreateInstance and ObjectFileMachO::CreateSections. This patch merely changes where the Symtab created from these merged sections ends up being stored.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65208/new/

https://reviews.llvm.org/D65208





More information about the lldb-commits mailing list